search

nuagenetworks / vspk-python

A Python library for managing Nuage through its API
http://www.nuagenetworks.net
BSD 3-Clause "New" or "Revised" License
17 stars 19 forks source link

async keyword fixes inherited from bambou #34

Closed tgoncuoglu closed 5 years ago

tgoncuoglu commented 5 years ago

These two changes are needed to fix vspk connection to bambou once they include the fixes for async keyword usage. In short, async became a keyword if python 3.7 and I did a pull request on bambou that changes the keyword "async" to the identifier "isasync". So that change needs also be done in vspk in the parameter calls for inherited class in nume.py . This would fix issue #32 .

However, to emphasize: for this fix to work first bambou has to accept their pull request, otherwise it would break vspk.

hellt commented 5 years ago

Thanks @tgoncuoglu

/cc @pdellaert

pdellaert commented 5 years ago

Thanks @tgoncuoglu, we'll have to carefully plan this to coordinate with our next Nuage major release as this breaks existing VSPK deployments and integrations. So we can't just do it now...

I'll track this

pdellaert commented 5 years ago

Closing this in favor of nuagenetworks/monolithe#123 and nuagenetworks/vspkgenerator#35