codecov-commenter
commented
2 years ago Codecov Report
Merging #208 (12be501) into master (3cd7bec) will decrease coverage by
0.25%. The diff coverage is93.41%.
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
- Coverage 94.69% 94.43% -0.26%
==========================================
Files 25 34 +9
Lines 1507 2068 +561
Branches 203 275 +72
==========================================
+ Hits 1427 1953 +526
- Misses 48 80 +32
- Partials 32 35 +3 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/fklearn/causal/validation/cate.py | 0.00% <0.00%> (ø) |
|
| src/fklearn/data/datasets.py | 100.00% <ø> (ø) |
|
| src/fklearn/tuning/parameter_tuners.py | 79.48% <ø> (ø) |
|
| src/fklearn/tuning/selectors.py | 90.47% <ø> (ø) |
|
| src/fklearn/validation/validator.py | 91.20% <88.88%> (-3.08%) |
:arrow_down: |
| src/fklearn/preprocessing/splitting.py | 95.00% <92.59%> (-0.84%) |
:arrow_down: |
| src/fklearn/training/calibration.py | 96.36% <94.73%> (-3.64%) |
:arrow_down: |
| src/fklearn/causal/cate_learning/meta_learners.py | 94.93% <94.93%> (ø) |
|
| src/fklearn/training/transformation.py | 93.95% <95.12%> (+0.02%) |
:arrow_up: |
| src/fklearn/validation/evaluators.py | 93.95% <96.29%> (+4.32%) |
:arrow_up: |
| ... and 19 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Status
IN DEVELOPMENT
Todo list
Background context
Depending on the data - if it has gaps that makes all the training start and end date be NaT, the validator function will break.
Description of the changes proposed in the pull request
This PR should fix the mentioned issue by skipping the folds where there is no training or testing data and saving these failure logs. The changes will only take effect if "drop_empty_folds" is set to be True, otherwise, the implementation of this function will remain as it was before.
Related PR