search

nubank / fklearn

fklearn: Functional Machine Learning
Apache License 2.0
1.51k stars 165 forks source link

Bumping the range of scikit-learn supported versions #217

Closed peguerosdc closed 1 year ago

peguerosdc commented 1 year ago

Status

READY

Todo list

(Nothing had to change in here)

Background context

Requiring a version of scikit-learn strictly lower tan 0.24 prevents the installation of fklearn in python 3.9. More context in this Slack thread.

Description of the changes proposed in the pull request

Versions of scikit-learn that can be installed in python 3.9 (and don't include any major change) are supported. The only breaking change is in IsolationForest, but a version check is added for backwards compatibility.

Where should the reviewer start?

Check the bump in the range of the scikit-learn supported versions and, if interested, check about the behaviour param in the IsolationForest's doc.

gcbeltramini commented 1 year ago

We need to figure out why the test is not running.

peguerosdc commented 1 year ago

I think CircleCI needs to be set up again

Screen Shot 2022-12-05 at 9 43 32
fpingas commented 1 year ago

Implemented in https://github.com/nubank/fklearn/pull/227