nubank / fklearn

fklearn: Functional Machine Learning
Apache License 2.0
1.51k stars 164 forks source link

Port project to Github Actions and bump dependencies to better support python 3.9 #225

Closed fpingas closed 1 year ago

fpingas commented 1 year ago

Status

READY

Todo list

Background context

CircleCI is not working consistently and the package takes ages to install in python 3.9 due to its dependency locks.

Description of the changes proposed in the pull request

Port CircleCI workflows to Github Action workflows, one push, for running test and code checks at every push for code quality, and one publish, for publishing the package when a new github release is published. This PR also updates the maximum allowed scikit-learn dependency so it installs quicker in 3.9.

codecov-commenter commented 1 year ago

Codecov Report

Merging #225 (2a8a099) into master (3cd7bec) will decrease coverage by 0.48%. The diff coverage is 93.05%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   94.69%   94.21%   -0.48%     
==========================================
  Files          25       34       +9     
  Lines        1507     2109     +602     
  Branches      203      281      +78     
==========================================
+ Hits         1427     1987     +560     
- Misses         48       84      +36     
- Partials       32       38       +6     
Impacted Files Coverage Δ
src/fklearn/causal/validation/cate.py 0.00% <0.00%> (ø)
src/fklearn/data/datasets.py 100.00% <ø> (ø)
src/fklearn/tuning/parameter_tuners.py 79.48% <ø> (ø)
src/fklearn/tuning/selectors.py 90.47% <ø> (ø)
src/fklearn/training/unsupervised.py 92.30% <60.00%> (-7.70%) :arrow_down:
src/fklearn/validation/validator.py 91.20% <88.88%> (-3.08%) :arrow_down:
src/fklearn/preprocessing/splitting.py 95.00% <92.59%> (-0.84%) :arrow_down:
src/fklearn/causal/cate_learning/meta_learners.py 93.02% <93.02%> (ø)
src/fklearn/training/calibration.py 96.36% <94.73%> (-3.64%) :arrow_down:
src/fklearn/training/transformation.py 93.95% <95.12%> (+0.02%) :arrow_up:
... and 15 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

fpingas commented 1 year ago

Implemented in https://github.com/nubank/fklearn/pull/227