nubank / matcher-combinators

Library for creating matcher combinator to compare nested data structures
Other
467 stars 23 forks source link

Make cljs version work with browser tests #189

Closed philomates closed 1 year ago

philomates commented 1 year ago

Should address https://github.com/nubank/matcher-combinators/issues/156 and https://github.com/nubank/matcher-combinators/issues/83, which @zampino and I ran into today ourselves. The idea behind the fix is to apply the changes done in https://github.com/nubank/matcher-combinators/commit/7635d040fb81ad44b3587644d75bba8961269dc7 for clj clojure.test to the cljs branch of the code.

note that I still haven't figured out how to get ansi color escape codes to print well in the browser. If anyone has ideas please chime in. (EDIT: calling (matcher-combinators.ansi-color/disable!) from https://github.com/nubank/matcher-combinators/pull/196 can do it) 20221213_17h25m12s_grim

I'm adding a deps.edn file for ease of launching shadow-cljs. I imagine nubank will still do deploys using its lein based-infra (assuming a migration over to clj deps hasn't happened yet) but probably still nice to have deps.edn as mentioned also by @lread in https://github.com/nubank/matcher-combinators/issues/188