nubank / matcher-combinators

Library for creating matcher combinator to compare nested data structures
Other
467 stars 23 forks source link

Create nested-equals matcher #218

Closed gilvan-reis closed 9 months ago

gilvan-reis commented 10 months ago

Create nested-equals function to match nested maps with equals and providing a documentation closer to the code about the nested behavior for matchers.

Closes https://github.com/nubank/matcher-combinators/issues/217

philomates commented 10 months ago

other possible names for deep-equals:

As a note, the midje implementation had a similar thing, match-equals, but the name isn't so great because it conflates the match construct with the combinators.

gilvan-reis commented 10 months ago

I think we should have equals in the function name, so I decided to follow with strictly-equals WDYT?

gilvan-reis commented 10 months ago

@philomates I have replaced the match-with example in the README. Feel free to inform me if you want to stay with both instead

gilvan-reis commented 10 months ago

I have also added the versions changes to be validated