nubisproject / nubis-kubernetes

Kubernetes deployment in Nubis
Mozilla Public License 2.0
1 stars 4 forks source link

Account Terraform and Kubernetes conflicting #24

Closed tinnightcap closed 6 years ago

tinnightcap commented 6 years ago

When executing a plan at the account level, terraform wants to strip Kubernetes labels. See output below

Terraform will perform the following actions:

  ~ module.vpcs.module.us-west-2.aws_subnet.private[0]
      tags.%:                                                                     "7" => "4"
      tags.SubnetType:                                                            "Private" => ""
      tags.kubernetes.io/cluster/kubernetes.us-west-2.nubis-jd.nubis.allizom.org: "shared" => ""
      tags.kubernetes.io/role/internal-elb:                                       "1" => ""

  ~ module.vpcs.module.us-west-2.aws_subnet.private[1]
      tags.%:                                                                     "7" => "4"
      tags.SubnetType:                                                            "Private" => ""
      tags.kubernetes.io/cluster/kubernetes.us-west-2.nubis-jd.nubis.allizom.org: "shared" => ""
      tags.kubernetes.io/role/internal-elb:                                       "1" => ""

  ~ module.vpcs.module.us-west-2.aws_subnet.private[2]
      tags.%:                                                                     "7" => "4"
      tags.SubnetType:                                                            "Private" => ""
      tags.kubernetes.io/cluster/kubernetes.us-west-2.nubis-jd.nubis.allizom.org: "shared" => ""
      tags.kubernetes.io/role/internal-elb:                                       "1" => ""

  ~ module.vpcs.module.us-west-2.aws_subnet.public[0]
      tags.%:                                                                     "7" => "4"
      tags.SubnetType:                                                            "Utility" => ""
      tags.kubernetes.io/cluster/kubernetes.us-west-2.nubis-jd.nubis.allizom.org: "shared" => ""
      tags.kubernetes.io/role/elb:                                                "1" => ""

  ~ module.vpcs.module.us-west-2.aws_subnet.public[1]
      tags.%:                                                                     "7" => "4"
      tags.SubnetType:                                                            "Utility" => ""
      tags.kubernetes.io/cluster/kubernetes.us-west-2.nubis-jd.nubis.allizom.org: "shared" => ""
      tags.kubernetes.io/role/elb:                                                "1" => ""

  ~ module.vpcs.module.us-west-2.aws_subnet.public[2]
      tags.%:                                                                     "7" => "4"
      tags.SubnetType:                                                            "Utility" => ""
      tags.kubernetes.io/cluster/kubernetes.us-west-2.nubis-jd.nubis.allizom.org: "shared" => ""
      tags.kubernetes.io/role/elb:                                                "1" => ""
limed commented 6 years ago

Unfortunately we need these tags, when we expose services to the internet kube tries to create an elb and with an elb it will need subnet info. And it grabs subnet info by reading the tags from my understanding