nublic / Nublic

Your home in Internet
6 stars 1 forks source link

Unknown artists and albums #64

Closed davisein closed 11 years ago

davisein commented 11 years ago

Hello both @serras and @PabloTunnon.

If a file is processed by the music previewer we get all metadata information. I have found a case where no album and artist can be guessed accurately.

My options are:

I like the second approach and I have the feeling that you both thought about that. Is there any special name that should be set on artists and albums so that the webapp is automatically aware of? What should I do to support it in an i18n way?

serras commented 11 years ago

There was already the idea of "unknown" artist or album. I think it was done by using an empty string as either the artist or the album. The music app already includes logic and i18n to handle this case and show it under "Unknown" headings.

2013/2/19 David Navarro Estruch notifications@github.com

Hello both @serras https://github.com/serras and @PabloTunnonhttps://github.com/PabloTunnon .

If a file is processed by the music previewer we get all metadata information. I have found a case where no album and artist can be guessed accurately.

My options are:

  • Do not include the file into the database (I don't like it since some files might not appear in the music app.
  • Add some kind of "unknown" flag to artists and albums. In that case both the webapp and the server must know about that "flag".

I like the second approach and I have the feeling that you both thought about that. Is there any special name that should be set on artists and albums so that the webapp is automatically aware of? What should I do to support it in an i18n way?

— Reply to this email directly or view it on GitHubhttps://github.com/nublic/Nublic/issues/64.

davisein commented 11 years ago

Ok, perfect. I'll stick to that convention in the fixes