search

nuchi / firefox-quantum-userchromejs

**Stops working with FF v72.** Firefox Quantum-compatible custom javascript in browser context — no extension, userChromeJS replacement.
MIT License
131 stars 16 forks source link

Ignore cache #8

Closed Kyuuhachi closed 5 years ago

Kyuuhachi commented 5 years ago

It seems a recent FF version changed loadSubScript so it uses a cache, which makes modifying userChrome.js a bit inconvenient. The loadSubScript line should be changed to Services.scriptloader.loadSubScriptWithOptions(makeRelativePathURI("userChrome.js"), {target: window, ignoreCache: true});, but I'm too lazy to make a proper pull request.

pm64 commented 5 years ago

As of 2/2019, firefox-quantum-userchromejs appears to no longer work.

Kyuuhachi commented 5 years ago

Really? I have a WIP plugin which depends heavily on this functionality, so that could be bad. I'll investigate later.

Kyuuhachi commented 5 years ago

Nope, works fine for me (with FF 65, on Arch).

Kyuuhachi commented 5 years ago

I had no issues at all, so that's pretty weird.

On Sat, Feb 2, 2019, 18:53 pm64 <notifications@github.com wrote:

@Caagr98 https://github.com/Caagr98, please let me know if you find differently. I tried for some time but was constantly thwarted by FF security.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nuchi/firefox-quantum-userchromejs/issues/8#issuecomment-459984896, or mute the thread https://github.com/notifications/unsubscribe-auth/ABebNkSUicwQyyorZ3G9uMKJDFDs3-Lrks5vJdCqgaJpZM4Y9WUB .

pm64 commented 5 years ago

I'm baffled. I tried testing by adding an alert("foo") to userChrome.js, which caused a security error to display in the console. Then I tried logging a message to the console, which also failed. Maybe I just need to read up on this a little more. Thank you for this encouraging information.

nuchi commented 5 years ago

works for me on version 66 beta. please open a new issue

nuchi commented 5 years ago

@Caagr98 — fixed in the latest commit. Thanks for the report and the fix suggestion.