nuclear-multimessenger-astronomy / nmma

A pythonic library for probing nuclear physics and cosmology with multimessenger analysis
https://nuclear-multimessenger-astronomy.github.io/nmma/
GNU General Public License v3.0
30 stars 58 forks source link

Exclude nan in injection test #172

Closed haukekoehn closed 1 year ago

haukekoehn commented 1 year ago

Sometimes the injection parameters cause the lightcurve to generate with nans. These need to be excluded in the comparison between function lightcurve and command line lightcurve

mcoughlin commented 1 year ago

@haukekoehn easiest way to deal with code linting is through the pre-commit:

pre-commit install pre-commit run --files YOUR_FILE_PATH_HERE

mcoughlin commented 1 year ago

@haukekoehn personally, it would be better if the nan commit was on its own branch, and the other commits on another branch. The nan lines look fine.

tsunhopang commented 1 year ago

I agree with @mcoughlin that I would prefer to have this changes to the tests on its own branch, without the acceleration to the GW analysis.