nuclear-multimessenger-astronomy / nmma

A pythonic library for probing nuclear physics and cosmology with multimessenger analysis
https://nuclear-multimessenger-astronomy.github.io/nmma/
GNU General Public License v3.0
33 stars 58 forks source link

Limit pandas to <2.0 for .pkl file compatibility #238

Closed bfhealy closed 1 year ago

bfhealy commented 1 year ago

This PR limits the required pandas version to < 2.0 to avoid a TypeError with pickled ZTF files (see #231).

mcoughlin commented 1 year ago

@sahiljhawar I think the cache needs to be rebuilt now that Kasen has been updated.

sahiljhawar commented 1 year ago

@mcoughlin Can you link me the new Kasen model files?

mcoughlin commented 1 year ago

@Theodlz @bfhealy can you share?

bfhealy commented 1 year ago

Just shared on google drive! The latest models should also be available at the updated Zenodo (https://zenodo.org/record/8346985).

sahiljhawar commented 1 year ago

@bfhealy Can you share the Drive link with me as well? It will easier be to download.

bfhealy commented 1 year ago

@sahiljhawar I shared it with the gmail address associated with your profile on slack. Should I share it with a different address?

sahiljhawar commented 1 year ago

Yeah got it. For some reason it was in the Spam folder.

sahiljhawar commented 1 year ago

@mcoughlin @bfhealy Updated the models with new Kasen files. All the tests with Python 3.8 passed while the test for analysis.py on other Python version failed due to error in Corner (matplotlib).

sahiljhawar commented 1 year ago

@mcoughlin Issue was with the Matplotlib latest release. Updated the requirements. Does this needs to be reported to Bilby? Already created a issue on corner.py.

mcoughlin commented 1 year ago

@sahiljhawar thanks! and report as needed for sure.

sahiljhawar commented 1 year ago

@tsunhopang Can you please raise this issue in Bilby? The issue is neither reproducible locally, nor by the Corner (independent of Bilby).

PS: I have checked the relevant Bilby code, and I cannot see if the issue is arising from there.