Closed mcoughlin closed 1 year ago
LGTM. Resolves #241
@mcoughlin Sorry I didn't notice but all the entry points has been renamed. Should I change all of them?
@sahiljhawar I think by convention, they should be "-" rather than "_"
yes, but this would mean that old workflow will be broken, those who are accustomed to do light_curve_analysis
, etc
@sahiljhawar I think we should make an announcement on list.
Okay! Docs needs to be updated as well.
@mcoughlin @sahiljhawar once we update the docs, perhaps we should tag this as a new release? since this alters the way users interact with most of the functions
It might also be worth (if possible) having some small period of deprecation where the old names are still callable to minimize compatibility issues with any users who updated without updating their existing codes that rely on nmma
But if we give the upgrade window, people will still be using the old names. How often do we seriosuly care about numpy or scipy deprecations?👀
I think as long as we do a bump to 0.1.0 we can justify the change.
I think as long as we do a bump to 0.1.0 we can justify the change.
that's a good point
A bump to 0.1.0 may also be a good time to start doing release notes
@sahiljhawar Can you write some release notes and then try a 0.1.0 release? I just pushed changes to the docs.
@mcoughlin @sahiljhawar while we're at it, we may as well remove the KNTimeshift deprecation warning if we're upgrading to 0.1.0
relevant commit: 4e30aad18e3c8a88ed4bacb22cff75d75cc230c6
@tylerbarna Yes!
@sahiljhawar just submitted #243 to address this
This PR tries to replace setup.py with pyproject.toml.