nuclear-multimessenger-astronomy / nmma

A pythonic library for probing nuclear physics and cosmology with multimessenger analysis
https://nuclear-multimessenger-astronomy.github.io/nmma/
GNU General Public License v3.0
33 stars 58 forks source link

Fixes for multimessenger analysis #252

Closed haukekoehn closed 1 year ago

sahiljhawar commented 1 year ago

@mcoughlin @bfhealy Maybe for now keep support for _tf and raise deprecation warning until the zenodo models are updated. And then release a minor version after this issue is patched?

mcoughlin commented 1 year ago

@sahiljhawar @bfhealy @haukekoehn I agree. Can we add an if else at the _tf check instead of just always looking for _tf?

bfhealy commented 1 year ago

@mcoughlin @sahiljhawar I agree with this as well. I can add a temporary check for <model>_tf.pkl if <model>.pkl can't be found. This may also require a temporary modification to get_model in models.py, which currently strips the _tf suffix off of the .pkl files it attempts to download.

bfhealy commented 1 year ago

@mcoughlin @sahiljhawar Just pushed a commit - the default modelfile remains <model>.pkl, but if that file is not found and --interpolation-type is tensorflow, the code will look for <model>_tf.pkl locally before downloading the same from Zenodo. New comments in model.py and models.py list what to remove once files on Zenodo are updated.

sahiljhawar commented 1 year ago

@mcoughlin Merge-ready?

mcoughlin commented 1 year ago

@sahiljhawar good for me!