Closed haukekoehn closed 1 year ago
@sahiljhawar @bfhealy @haukekoehn I agree. Can we add an if else at the _tf check instead of just always looking for _tf?
@mcoughlin @sahiljhawar I agree with this as well. I can add a temporary check for <model>_tf.pkl
if <model>.pkl
can't be found. This may also require a temporary modification to get_model
in models.py
, which currently strips the _tf
suffix off of the .pkl files it attempts to download.
@mcoughlin @sahiljhawar Just pushed a commit - the default modelfile
remains <model>.pkl
, but if that file is not found and --interpolation-type
is tensorflow
, the code will look for <model>_tf.pkl
locally before downloading the same from Zenodo. New comments in model.py
and models.py
list what to remove once files on Zenodo are updated.
@mcoughlin Merge-ready?
@sahiljhawar good for me!
@mcoughlin @bfhealy Maybe for now keep support for
_tf
and raise deprecation warning until the zenodo models are updated. And then release a minor version after this issue is patched?