nuclear-multimessenger-astronomy / nmma

A pythonic library for probing nuclear physics and cosmology with multimessenger analysis
https://nuclear-multimessenger-astronomy.github.io/nmma/
GNU General Public License v3.0
30 stars 58 forks source link

Update analysis_slurm.py code for smoother analyses on Expanse #258

Closed bfhealy closed 11 months ago

bfhealy commented 11 months ago

This PR adjusts analysis_slurm.py to facilitate smoother analyses with Expanse:

mcoughlin commented 11 months ago

@bfhealy feel free to merge once tests pass

sahiljhawar commented 11 months ago

Tests failing!

analysis_slurm.main() is called without any arguments, even without slurm specific arguments!? Also I think args in test_analysis should be global so that test_analysis args’ can be accessed by test_analysis_slurm().

sahiljhawar commented 11 months ago

@mcoughlin I don't know about rebasing and dont want to mess up. Can you please merge this?