search

nuclear-multimessenger-astronomy / nmma

A pythonic library for probing nuclear physics and cosmology with multimessenger analysis
https://nuclear-multimessenger-astronomy.github.io/nmma/
GNU General Public License v3.0
30 stars 58 forks source link

Add support for user-specified filters in API analyses #285

Closed bfhealy closed 9 months ago

bfhealy commented 9 months ago

This PR adds support for a list of filters to be passed to the API for analysis. The local API is modified here, along with the code to generate a slurm script for Expanse/HPC resources. Additionally, a two-line change to analysis.py ensures that the code will behave as expected if the string "None" (rather than None) is given to the --filters argument.

A companion PR to nmma-api (https://github.com/Theodlz/nmma-api/pull/13) adds compatibility for user-specified filters.

bfhealy commented 9 months ago

Note - this PR will become unnecessary if filters/instruments are handled at the SkyPortal level.

bfhealy commented 9 months ago

This will be addressed at the SkyPortal level (see https://github.com/skyportal/skyportal/pull/4669)