search

nuclear-multimessenger-astronomy / nmma

A pythonic library for probing nuclear physics and cosmology with multimessenger analysis
https://nuclear-multimessenger-astronomy.github.io/nmma/
GNU General Public License v3.0
33 stars 58 forks source link

Add tool to convert skyportal lightcurves to nmma format #304

Closed bfhealy closed 9 months ago

bfhealy commented 10 months ago

This PR adds a tool to convert light curves downloaded from the skyportal/fritz frontend to NMMA format. Also, the Injections & observational data documentation is updated with an example lightcurve downloaded from SkyPortal.

mcoughlin commented 10 months ago

@bfhealy in show photometry table, I get mag and magerr. I opened a quick PR for the export button (https://github.com/skyportal/skyportal/pull/4708), although honestly I kind of wonder if we should remove this button and focus on the photometry table, which seems better. What do you think?

bfhealy commented 10 months ago

@mcoughlin Thanks for that PR - I also think the photometry table is the better place to be downloading lightcurves (I was testing only with the "Export Bold Light Curve to CSV" button).

mcoughlin commented 10 months ago

@bfhealy https://github.com/skyportal/skyportal/pull/4709

bfhealy commented 10 months ago

@mcoughlin Any concern about the test failures? They look to be related to coveralls.

mcoughlin commented 10 months ago

@bfhealy not really. can usually rerun those tests.