search

nuclear-multimessenger-astronomy / nmma

A pythonic library for probing nuclear physics and cosmology with multimessenger analysis
https://nuclear-multimessenger-astronomy.github.io/nmma/
GNU General Public License v3.0
32 stars 58 forks source link

LANL1D model addition #379

Open mreuter01 opened 2 months ago

mreuter01 commented 2 months ago

This fork is the repository I built my new model on. It runs successfully with the rest of NMMA and does not interfere with the function of other people's models and/or other functions within the code.

sahiljhawar commented 2 months ago

@mreuter01 I am assuming this model uses SVDLightCurveModel, if so, can you point to the model files as well?

sahiljhawar commented 2 months ago

@mreuter01 also, any reference paper for this model?

bking-astro commented 2 months ago

@mreuter01 I am assuming this model uses SVDLightCurveModel, if so, can you point to the model files as well?

What do you mean by this Sahil?

@mreuter01 remove the unnecessary commented lines please

mreuter01 commented 2 months ago

@mreuter01 also, any reference paper for this model?

@sahiljhawar fixed.

@mreuter01 remove the unnecessary commented lines please

@bking-astro fixed.

sahiljhawar commented 2 months ago

@bking-astro SVD files (h5 or pkl files). If such files exists, those needs to be added to the gitlab repo

mreuter01 commented 2 months ago

@bking-astro SVD files (h5 or pkl files). If such files exists, those needs to be added to the gitlab repo

They should be added now. Let me know if there's something else I need to do.

sahiljhawar commented 2 months ago

LGTM

sahiljhawar commented 2 months ago

@bking-astro feel free to merge if you are okay with this