lafiosca
commented
1 year ago Thanks for the details. I have labeled the issue and will leave it open. Unfortunately the library has not been maintained/tested with newer versions of RN and RNGH, and it's possible something changed. It's been quite a while since I worked on that code, but I assume the reason I was checking for explicit finish of the animation was in case another animation interrupted it. One of the manual tests I used to perform with the Drax example project was to set a really long/slow snapback and see how the hover views behaved if I dragged somewhere, released, and then dragged again while the snapback was still happening. Sadly I do not remember more than that, and I suspect that if we were to outright remove the "finished" check like your patch does, we might break existing functionality on older versions.
LunatiqueCoder
Hi, have a Drag and Drop feature where a card is snapped onto another card using DragView.
After the updates: "react-native": "0.72.4", "react-native-gesture-handler": "~2.12.0", "expo": "49.0.8",
When dragging a card out of a slot, it used to return to its original position. However, after the updates, the card remains stuck on the screen. Example:
While debugging the code, I noticed that in the useDraxRegistry hook in method resetDragInRegistry, when calling animation.start for snapback, the finished parameter is consistently being returned as false. To work around this issue, I created a patch that removes the if (finished) {} statement.
I also tested with the version 2.9.0 of react-native-gesture-handler, which was the version before the update, but the issue persists. I believe the problem lies within the React Native Animated module.
As I need to quickly release a fix for my app, this was the solution. However, we need to understand why finished is always false. I believe the animation is never being initiated.