search

nuclearpasta / react-native-drax

A drag-and-drop system for React Native
MIT License
554 stars 69 forks source link

Fix: Draggable view stuck on screen after release #163

Closed Georgio-Saad closed 1 year ago

lafiosca commented 1 year ago

@Georgio-Saad Since I am not actively maintaining this and cannot test the changes, do you know why the finished parameter is not true? Is this covering some cases where the animation is somehow interrupted when no other logic has taken control of the view?

LunatiqueCoder commented 1 year ago

I tried out the changes, and they seem to have fixed the issue in our project. The finished parameter is always showing as false, but we're not sure why. We'll keep looking into it on our end. Dealing with the intricacies of react-native-drax takes time to get used to, even though the code is well written and easy to understand.

LunatiqueCoder commented 1 year ago

@lafiosca I managed to fix the issue by forking and migrating to react-native-reanimated, where the finished functionality works as expected. There's still a little bit of tinkering left to do, but we plan to start testing next week and will keep you posted on the outcome. If everything goes well for our project, we'd love to contribute back if you're interested in those changes.

lafiosca commented 1 year ago

Very interesting, thank you for the followup!

lafiosca commented 1 year ago

Closing this PR for now

vchaitanya88 commented 9 months ago

is this fixed? can you tell me how to fix it?