search

nuclearpasta / react-native-drax

A drag-and-drop system for React Native
MIT License
554 stars 69 forks source link

Add draggable & onScroll props to DraxList #64

Closed afgarcia86 closed 3 years ago

afgarcia86 commented 4 years ago

This was surprisingly easy to add. Its been a minute since I used standard git so did some strange stuff with my commit history. Happy to clean it up if you guys have any comments.

lafiosca commented 4 years ago

I will try to take a look and review this week, although I am on vacation so no promises 😅

lafiosca commented 3 years ago

@afgarcia86 I'm so sorry I've taken FOREVER go get around to this PR. My life circumstances have not afforded me the availability to work on Drax significantly over the past year. I am trying to address some of these old issues and PRs now and have reviewed these changes. I will add comments on individual lines.

afgarcia86 commented 3 years ago

Awesome I appreciate that!

lafiosca commented 3 years ago

Superseded by #86