search

nuclearpasta / react-native-drax

A drag-and-drop system for React Native
MIT License
554 stars 69 forks source link

Masonic/Multi Column support #67

Closed afgarcia86 closed 3 years ago

afgarcia86 commented 4 years ago

Helps with issue #14

I based this off of the multicolumn branch changes but added some other potential improvements.

I was having issues getting above the top of multi column items worse

With this change it smoother and switches between two different transitions based on the direction I am dragging. better

afgarcia86 commented 4 years ago

https://snack.expo.io/@afgarcia86/react-native-drax---masonic-reorderable-list <- meant to share this example as well I am able to pull off the masonic layout by adding "placeholders"

lafiosca commented 4 years ago

Wow, thank you. I will dig into these PRs as soon as I’m available.

afgarcia86 commented 4 years ago

I went ham on this for fun this morning and made a even more dynamic example: https://snack.expo.io/@afgarcia86/react-native-drax---masonic-reorderable-list-v2

IMG_0578

afgarcia86 commented 3 years ago

@lafiosca any update on these PR's would love to use the official package in our app.

lafiosca commented 3 years ago

@afgarcia86 I apologize greatly and feel so guilty over how long it's taking me to review this and other issues/PRs on this library. I'm currently dealing with a situation in my life which has not afforded me the time to work on this project, and I cannot predict how soon I'll be available. I would like to make sure I thoroughly understand and agree with the code before merging it.

I know this is a frustrating suggestion, but I often use patch-package for my own projects in situations like this. I find it to be a solid tool when I want to use an "official" package but it's missing commits that I require for my app.

afgarcia86 commented 3 years ago

I totally understand, hope you have a good holiday. If you have any questions when you get back to this please don't hesitate to ask.

lafiosca commented 3 years ago

@afgarcia86 I'm sorry it's taken so long to get back to you, and I'm sure this is no longer fresh in your mind, but is there any chance you'd be available to get together for a code review and discuss this feature/PR sometime?

afgarcia86 commented 3 years ago

Hey Joe,

I am up for that. Let me know if you want to schedule something for next week. I will have to refresh myself as well.

I am on Eastern Time and am pretty flexible.

On Thu, Apr 29, 2021 at 4:54 PM Joe Lafiosca @.***> wrote:

@afgarcia86 https://github.com/afgarcia86 I'm sorry it's taken so long to get back to you, and I'm sure this is no longer fresh in your mind, but is there any chance you'd be available to get together for a code review and discuss this feature/PR sometime?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nuclearpasta/react-native-drax/pull/67#issuecomment-829589100, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3QMJJCOBVERU4KMEVN2DLTLHBP5ANCNFSM4TVVGMLA .

-- Best Regards,

Andres Garcia Software Engineer http://www.andresthegiant.comhttp://www.andresthegiant.com 703.389.1081

lafiosca commented 3 years ago

@afgarcia86 I'm east coast too. I will send you an email!

micaelillos commented 3 years ago

Hi is this available to use ?

lafiosca commented 3 years ago

@micaelillos Sorry, we haven't managed to connect to review it yet.

afgarcia86 commented 3 years ago

@lafiosca let me know if you want to try to sync on this soon.

lafiosca commented 3 years ago

@afgarcia86 Sounds good! If you don't mind, shoot me an email at joe@lafiosca.com and let me know if any afternoon times next week work for you :)