search

nuclearpasta / react-native-drax

A drag-and-drop system for React Native
MIT License
554 stars 69 forks source link

DraxList not work in android #84

Open mohamedanwer123 opened 3 years ago

mohamedanwer123 commented 3 years ago

drap and drop of DraxList not work in android but work fine in ios

lafiosca commented 3 years ago

@mohamedanwer123 I just ran into this issue in my own app a few days ago as well. I think there must have been a breaking change at some point, perhaps when we updated the lib between RN versions. I am not sure how soon I will be able to look into it, but I wanted to acknowledge that you are correct.

mohamedanwer123 commented 3 years ago

It worked in android when wraped the component by gesture handler @lafiosca

lafiosca commented 3 years ago

@mohamedanwer123 Could you provide some example code of what you did?

lafiosca commented 3 years ago

Hmm, it seems to me that the DraxList in react-native-drax-example works both in the emulator and on a physical device, so I am wondering if this is some kind of library interaction with something else I'm using in my app.

lafiosca commented 3 years ago

If anyone else runs into trouble with this issue, please share information here about your specific use case so we can try to track down a minimal reproduction and potential workaround.

hokaiyipFS commented 3 years ago

@lafiosca I think I may find someone who posted a solution. check

https://github.com/DevanshaniR/ReactnativeDragDropApp/blob/master/App.js

lafiosca commented 3 years ago

Thank you.

welsdarte commented 3 years ago

thanks

Seelvex commented 3 years ago

@lafiosca I think I may find someone who posted a solution. check

https://github.com/DevanshaniR/ReactnativeDragDropApp/blob/master/App.js

Wrapping the container View with GestureHandlerRootView from "react-native-gesture-handler" actually solved the issue. If this is an intentional behaviour, it should be disclosed on README.

lafiosca commented 3 years ago

Thanks @Seelvex, that seems like a helpful starting point to investigate this. When the library was built, that was not necessary (if it even existed). Perhaps that need was introduced in one of the RNGH releases since Drax was first developed.

GNUGradyn commented 1 year ago

Is this still being worked on?

lafiosca commented 1 year ago

Is this still being worked on?

No one is currently working on this library, unfortunately. I apologize for that.

GNUGradyn commented 1 year ago

No one is currently working on this library, unfortunately. I apologize for that.

Thanks for responding at least. Accepting pull requests?

lafiosca commented 1 year ago

Thanks for responding at least. Accepting pull requests?

I still accept simple PRs and publish minor version updates when it's obvious what they do, but I am not really set up for validating functionality of non-trivial changes. And the library has not been updated for the more recent versions of RN and RNGH. It's pretty dusty at this time. I am open to ideas from potential maintainers about how to transition this project if there are volunteers with more time and energy available, or perhaps it might make more sense for someone to fork it (or even just mimic the concepts).