search

nuclearpasta / react-native-drax

A drag-and-drop system for React Native
MIT License
554 stars 69 forks source link

add ability to use ref with DraxList #85

Closed chrisdrackett closed 3 years ago

lafiosca commented 3 years ago

Ah, the wonderful nightmare of TypeScript types and forwarded ref function components

lafiosca commented 3 years ago

@chrisdrackett I see new commits have been coming in. Are you still finding bugs and improving the PR?

lafiosca commented 3 years ago

I wonder if it would be better for us to rename the prop to something specific like flatListRef, reserving the ability for us to add an actual DraxList ref in the future if we want to expose any imperative methods. I am not sure what imperative methods a DraxList might need beyond those provided by FlatList though.

lafiosca commented 3 years ago

Drax 0.9.1 has been released, which forwards refs for DraxScrollView #117 and DraxList #118 imperative calls, as well as fixing the handling of style on DraxScrollView #119

I apologize for how long this took!