search

nuclearpasta / react-native-drax

A drag-and-drop system for React Native
MIT License
554 stars 69 forks source link

Masonic/Multi Column support [Cleaner Rebase] #99

Open afgarcia86 opened 3 years ago

afgarcia86 commented 3 years ago

related: https://github.com/nuclearpasta/react-native-drax/pull/67

lafiosca commented 3 years ago

The good news is that ultimately there doesn't seem to be a lot of code for us to review! Still I'd love to step through it and work an example together to understand what's going on here and any potential gaps it has. Thank you!

afgarcia86 commented 3 years ago

If you wanted to try to get together now and crank this out I can be available.

On Mon, Jun 14, 2021 at 9:40 PM Joe Lafiosca @.***> wrote:

The good news is that ultimately there doesn't seem to be a lot of code for us to review! Still I'd love to step through it and work an example together to understand what's going on here and any potential gaps it has. Thank you!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nuclearpasta/react-native-drax/pull/99#issuecomment-861105601, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3QMJNBGYFGPR4BRAJ7QDDTS2VPFANCNFSM46PEJMUA .

-- Best Regards,

Andres Garcia Software Engineer http://www.andresthegiant.comhttp://www.andresthegiant.com 703.389.1081

lafiosca commented 3 years ago

Sorry for the hit and run comments yesterday @afgarcia86 I jumped offline for the day right after that!

StevenGonzalez commented 2 years ago

@lafiosca @afgarcia86 Hello, I was wondering what the state of this PR was. This change appears to be what I am needing for my project, but it appears that the PR may have been forgotten.

lafiosca commented 2 years ago

Hi @StevenGonzalez. I apologize but Andres and I never managed to coordinate our schedules to review this together, and it fell to the wayside as you noted. Unfortunately, these days I do not have availability to work on significant features like this for the repo. If this PR can suit your needs, I encourage you to use patch-package or a custom fork.