nuclearsilo583 / zephyrus-store-preview-new-syntax

My rewritten zephyrus store
61 stars 40 forks source link

[CS:GO] "sm_store_chat_tag_plugins" cvar problem #162

Closed VaaLaaKi closed 1 year ago

VaaLaaKi commented 1 year ago

Messages are not preceded by "[Store] ".

Screenshot_3

Am I doing something wrong?

azalty commented 1 year ago

I think I might have identified the problem. Can you try changing sm_store_chat_tag_plugins to something else, then back to "[Store] " again, and see if it works?

But yea it's a bit weird that I didn't experience this

VaaLaaKi commented 1 year ago

I started the server. I typed in console: sm_rcon sm_store_chat_tag_plugins "[Store] " Restarted the map. The "[Store] " text did not work.

I typed in console: sm_rcon sm_store_chat_tag_plugins "Test " Restarted the map. Now the "[Store ] " text works.

I restarted the server. Again, the "[Store] " text does not work.

azalty commented 1 year ago

I typed in console: sm_rcon sm_store_chat_tag_plugins "Test " Restarted the map. Now the "[Store ] " text works.

Did it show [Store] or Test?

Also, which version of the plugin are you running?

VaaLaaKi commented 1 year ago

"[Store] " text appeared, not "Test ". I downloaded from the main page, should I download the "Releases" version instead? image

azalty commented 1 year ago

no, the master branch is more up to date, but the latest confirmed to be working version is the release. Stay with the current version if you're not experiencing serious issues.

I'm personally on a modified 7.0.4 version. I'll try to switch to the latest version to see if I can reproduce this, and I'll continue checking the code.


Currently, the tag is cached in a variable. This variable caches the tag when the convar linked to it is modified, but it might not be modified if it is the same as the default value. Changing the tag to something else, then back to "[Store] " WITHOUT changing maps should also work if I'm correct.

This "temporary fix" will cease to work when the server is restarted OR the plugin is reloaded. It should survive map changes.

azalty commented 1 year ago

I can confirm this bug exists, and the reason is the one I wrote. I'm writing a fix for that.

VaaLaaKi commented 1 year ago

I tested it, it works, thank you.