search

nucleartide / ember-elm

Write Elm in your Ember app
https://medium.com/@nucleartide/introducing-ember-elm-d47f2af73aff
Other
55 stars 7 forks source link

Fix option loading, and don't register complier for the addon itself. #17

Closed MattCheely closed 6 years ago

MattCheely commented 6 years ago

I hit some issues loading options from our app's ember-cli-build.js, which I belive was working before. Not sure if something changed in newer versions of ember or if this was always broken.

I also stopped the preprocessor from registering for building the addon itself, since there's no actual elm code in the addon. That prevents build failures when the path to elm-make is configured in the parent application. The self registry doesn't see the elm-make path option, and fails when elm isn't installed globally, even though there are no actual files to compile.

nucleartide commented 6 years ago

Looks good to me, thanks!

nucleartide commented 6 years ago

Released v0.2.1 on npm too.