search

nucleartide / ember-elm

Write Elm in your Ember app
https://medium.com/@nucleartide/introducing-ember-elm-d47f2af73aff
Other
55 stars 7 forks source link

Change project structure? #22

Open MattCheely opened 6 years ago

MattCheely commented 6 years ago

One thing that got a bit more difficult with the move to 0.19 is testing. With support for tests more closely built into the package format, elm-test is now more rigorous about where tests live, expecting them directly in tests/ at the project root, where Ember also likes to keep other test structures.

It might be cleaner to completely separate out Elm into it's own sub-project, and add some Ember-CLI commands to manage package installs and such. Would you be open to a PR with those changes?

nucleartide commented 6 years ago

Yeah definitely!

I'd also be open to adding you as a maintainer if you're interested. 🙂 Just so I'm not the blocker for any of the changes you want to make.

ondrejsevcik commented 6 years ago

Does this mean it's going to be upgraded to 0.19?

MattCheely commented 6 years ago

@nucleartide Yeah, I'd be happy to be a maintainer, thanks!

@ondrejsevcik already done in #21! Just needs to be published to npm.

nucleartide commented 6 years ago

@MattCheely Cool! Lemme add you to the repo. I'll also give you publish rights, lemme set a reminder.

nucleartide commented 6 years ago

@MattCheely Added you to the npm repo as well!

MattCheely commented 6 years ago

@nucleartide Thanks!

MattCheely commented 6 years ago

@ondrejsevcik Took me a while to get around to it, but I've finally published support for Elm 0.19 to npm as ember-elm@0.3.0

ondrejsevcik commented 6 years ago

No worries and big thanks 🙏🏽