nucleartide / ember-elm

Write Elm in your Ember app
https://medium.com/@nucleartide/introducing-ember-elm-d47f2af73aff
Other
55 stars 7 forks source link

Upgrade to elm 0.19.1 #45

Closed jalandis closed 4 years ago

jalandis commented 4 years ago

Upgrades to the latest version of Elm adding a configuration option to work around requirement for main values in compilation targets.

omarestrella commented 4 years ago

Thanks for providing a solution so quickly!

jalandis commented 4 years ago

@nucleartide @MattCheely Just wanted to give this a bump. I am hoping to upgrade elm and ember here in order to ensure my projects dependencies stay current and secure.

If you would take a look at this pull request when you get a chance, it would be appreciated.

MattCheely commented 4 years ago

Sorry for the delay! I am going to try to take a look at this and get it updated this week.

MattCheely commented 4 years ago

We pulled this into our project this week (@omarestrella gets the credit) and it looks like compliation is successful, but we end up getting a runtime error: SyntaxError: export declarations may only appear at top level of a module

It seems to be due to this line: https://github.com/nucleartide/ember-elm/blob/master/broccoli-elm/index.js#L62

I'm guessing something has changed in the JS output in 0.19.x to make that line unnecessary or invalid.

ondrejsevcik commented 4 years ago

@MattCheely I've faced the same issue. I was only able to figure out that it depends on Ember environment. https://discuss.emberjs.com/t/compiled-js-output-is-imported-differently-depending-on-environment/16471

But so far no universal fix for it.

thematthopkins commented 4 years ago

@omarestrella @MattCheely - when you get a chance, could you see if the latest commit addresses the issues you experienced in your project?

Thanks!!!

MattCheely commented 4 years ago

I should be able to check it this week, probably tomorrow if I can't squeeze it in between meetings today.

MattCheely commented 4 years ago

Published as 1.0.0