nucleic / enaml

Declarative User Interfaces for Python

http://enaml.readthedocs.io/en/latest/

Other

1.54k stars 131 forks source link

Improve error reporting on invalid syntax for f-strings #378

Closed MatthieuDartiailh closed 5 years ago

MatthieuDartiailh commented 5 years ago

Closes #377

This requires tests and release notes updates

codecov-io commented 5 years ago

Codecov Report

Merging #378 into master will increase coverage by 0.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
+ Coverage   72.29%   72.31%   +0.01%     
==========================================
  Files         312      312              
  Lines       23305    23317      +12     
==========================================
+ Hits        16849    16861      +12     
  Misses       6456     6456

MatthieuDartiailh commented 5 years ago

Thanks for the review.

MatthieuDartiailh commented 5 years ago

This is ready to merge from my point of view. Care to do a second review @frmdstryr ?

frmdstryr commented 5 years ago

Works good. Also works for missing & empty brackets now too. Thanks!