nucleic / enaml

Declarative User Interfaces for Python

http://enaml.readthedocs.io/en/latest/

Other

1.54k stars 131 forks source link

parser: allow alias and const not to be keywords #382

Closed MatthieuDartiailh closed 4 years ago

MatthieuDartiailh commented 5 years ago

This implements the solution 2 outlines in #380. Except for the need to manually filter out possibly wrong nodes this looks reasonably clean to me.

Existing tests pass but we probably need some extra ones.

codecov-io commented 5 years ago

Codecov Report

Merging #382 into master will decrease coverage by 0.02%. The diff coverage is 94.87%.

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
- Coverage   71.75%   71.72%   -0.03%     
==========================================
  Files         308      308              
  Lines       22810    22805       -5     
==========================================
- Hits        16367    16358       -9     
- Misses       6443     6447       +4

MatthieuDartiailh commented 5 years ago

The one failure we have is under Python 2 and since I won't make a bugfix release for that it will be fine since we are dropping Python 2. I will try to merge the cppy PR soon to make that clear.

frmdstryr commented 5 years ago

I'd rather have python 2 support than alias and const not being keywords.

MatthieuDartiailh commented 5 years ago

I won't support Python 2 after january 2020 and I don't plan a release between now and then.

MatthieuDartiailh commented 4 years ago

This is ready to be merged from my point of view and will be next week if nobody complains before then.