Closed AndiEcker closed 4 years ago
Thanks since this is the second bug in the same region. I will try to add some tests to avoid future regression before merging.
Thanks Matthieu - the new tests will be very helpful for me for to learn how to also write some tests for the planned No-Focus implementation.
Am So., 5. Apr. 2020 um 20:30 Uhr schrieb Matthieu Dartiailh < notifications@github.com>:
Thanks since this is the second bug in the same region. I will try to add some tests to avoid future regression before merging.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nucleic/enaml/pull/404#issuecomment-609469559, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4U63XSSQZIKWNEJEEIQLTRLDL3PANCNFSM4MBKDI5Q .
Merging #404 into master will decrease coverage by
1.84%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #404 +/- ##
==========================================
- Coverage 71.21% 69.36% -1.85%
==========================================
Files 311 308 -3
Lines 23776 23039 -737
==========================================
- Hits 16931 15981 -950
- Misses 6845 7058 +213
I added tests that currently fails on Travis (not sure why) however I was unable to reproduce your issue locally. Since the change seems reasonable though I will probably merge as soon as the Cis are fine.
Trying to kick Github actions
hope it will be PR 404