nucleic / enaml

Declarative User Interfaces for Python

http://enaml.readthedocs.io/en/latest/

Other

1.53k stars 130 forks source link

Remove signaling and update cis #412

Closed MatthieuDartiailh closed 4 years ago

codecov-io commented 4 years ago

Codecov Report

Merging #412 into master will increase coverage by 1.72%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
+ Coverage   71.38%   73.11%   +1.72%     
==========================================
  Files         311      308       -3     
  Lines       23776    23215     -561     
==========================================
  Hits        16973    16973              
+ Misses       6803     6242     -561

MatthieuDartiailh commented 4 years ago

The failure first seen in Python 3.8 was the use of METH_KEYWORDS alone in signaling.cpp. Fixing that on 0.10.4 (before the cppy update), and adding the tests from https://github.com/nucleic/enaml/tree/signaling-testing uncover a lot more bugs including fairly cryptic ones where a python frame manage to replace a class ! This is real pain to track and is added motivation to simply remove it. I will leave this open for 2 more weeks and merge on May the 3rd, if anybody really need signaling please let yourself be known and if you can please try to investigate the issues.

MatthieuDartiailh commented 4 years ago

Closed in favor of #416, thanks to the discussion in #411