nucleic / enaml

Declarative User Interfaces for Python

http://enaml.readthedocs.io/en/latest/

Other

1.53k stars 130 forks source link

Coerce a Loopers iterable to a tuple if it is an iterator #415

Closed frmdstryr closed 4 years ago

frmdstryr commented 4 years ago

For #414.

Not sure if there's a better way to do this.

codecov-io commented 4 years ago

Codecov Report

Merging #415 into master will increase coverage by 0.01%. The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
+ Coverage   71.38%   71.40%   +0.01%     
==========================================
  Files         311      311              
  Lines       23776    23789      +13     
==========================================
+ Hits        16973    16986      +13     
  Misses       6803     6803

frmdstryr commented 4 years ago

Ooops, this doesn't handle non-iterable's properly...

MatthieuDartiailh commented 4 years ago

Also don't forget to update the release notes.

MatthieuDartiailh commented 4 years ago

This looks all good. Thanks for the patch I will merge shortly.