nucleic / enaml

Declarative User Interfaces for Python

http://enaml.readthedocs.io/en/latest/

Other

1.53k stars 130 forks source link

Add support for Pyside2 and avoid using deprecated API #423

Closed MatthieuDartiailh closed 3 years ago

MatthieuDartiailh commented 4 years ago

Qt 5.15 started to mark as obsolete a number of feature related to Screen detection. We use the new alternative that remain compatible with qt 5.9+.

codecov-commenter commented 4 years ago

Codecov Report

Merging #423 into master will increase coverage by 0.16%. The diff coverage is 80.85%.

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
+ Coverage   73.35%   73.51%   +0.16%     
==========================================
  Files         311      311              
  Lines       23788    23782       -6     
==========================================
+ Hits        17449    17483      +34     
+ Misses       6339     6299      -40

MatthieuDartiailh commented 4 years ago

If anybody has access to a multiple monitor display, I would appreciate if somebody could test the behavior of popups when the parent is close to the edge.

codecov-io commented 3 years ago

Codecov Report

Merging #423 into master will increase coverage by 0.06%. The diff coverage is 80.85%.

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
+ Coverage   73.53%   73.59%   +0.06%     
==========================================
  Files         311      311              
  Lines       23815    23790      -25     
==========================================
- Hits        17513    17509       -4     
+ Misses       6302     6281      -21