nucleic / enaml

Declarative User Interfaces for Python

http://enaml.readthedocs.io/en/latest/

Other

1.53k stars 130 forks source link

Allow to explicitly set Qt application name #430

Closed adigitoleo closed 3 years ago

adigitoleo commented 3 years ago

The argument to QApplication is used to set the application name. On Linux (Xorg) this can be queried using the xprop utility. Specifically, this name will be used for the WM_CLASS property [1], which can be used by X-based window managers to manipulate window placement and app-specific behaviour (automatic floating, tiling, positioning, etc). The approach proposed here is used by Jupyter's QtConsole [2] for example.

[1] https://tronche.com/gui/x/icccm/sec-4.html#WM_CLASS [2] jupyter/qtconsole#16

This is only for the Qt backend.. I'm not familiar with the other frameworks.

[x] Modify enaml.qt.qt_application.QtApplication
[x] Update releasenotes.rst
[ ] Add test case

codecov-io commented 3 years ago

Codecov Report

Merging #430 (9b2b15f) into master (bddadfc) will decrease coverage by 0.00%. The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
- Coverage   73.72%   73.72%   -0.01%     
==========================================
  Files         312      312              
  Lines       23821    23823       +2     
==========================================
+ Hits        17562    17563       +1     
- Misses       6259     6260       +1

MatthieuDartiailh commented 3 years ago

The links provided sound convincing to me. Could you please update the changelog and then I will merge ?

adigitoleo commented 3 years ago

OK I added this to releasenotes.rst, is that what you mean? Sorry if I misunderstood, I can fix it if it's incorrect.

MatthieuDartiailh commented 3 years ago

That's good, however I am unlikely to release today, so please replace the date by unreleased. Also if you can add a Linux specific test for the new feature, it would be great.