nucleic / enaml

Declarative User Interfaces for Python

http://enaml.readthedocs.io/en/latest/

Other

1.53k stars 130 forks source link

Fix template instance operator binding. #445

Closed MatthieuDartiailh closed 3 years ago

MatthieuDartiailh commented 3 years ago

Template instance operator binding require some extra work compared to conventional operator binding since we need both the node where the template is instantiated and where it is defined. However the analysis of globals and comprehensions performed for standards operators apply but was not carried out previously. This bug has been there for quite some time and was likely introduced when migrating to Python 3.

This needs tests before it can be merged.

codecov-commenter commented 3 years ago

Codecov Report

Merging #445 (5a54c42) into main (d9bc860) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   73.47%   73.47%           
=======================================
  Files         316      316           
  Lines       24060    24061    +1     
=======================================
+ Hits        17677    17678    +1     
  Misses       6383     6383