search

nucleic / enaml

Declarative User Interfaces for Python
http://enaml.readthedocs.io/en/latest/
Other
1.53k stars 130 forks source link

Qt6 support #475

Closed MatthieuDartiailh closed 2 years ago

MatthieuDartiailh commented 2 years ago

WIP on adding support for Qt6

codecov-commenter commented 2 years ago

Codecov Report

Merging #475 (885cfec) into main (0ad2793) will increase coverage by 0.07%. The diff coverage is 86.11%.

@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
+ Coverage   73.06%   73.14%   +0.07%     
==========================================
  Files         316      318       +2     
  Lines       24125    24137      +12     
  Branches       55       55              
==========================================
+ Hits        17628    17654      +26     
+ Misses       6497     6483      -14
MatthieuDartiailh commented 2 years ago

Apart from the appveyor failure this looks good but I did not test it on any large application yet. @bburan is Qt6 support something you are interested in ?

bburan commented 2 years ago

@MatthieuDartiailh I wasn't even aware that Qt had come out with a new major release! Looking at the end of life for Qt5, it looks like it's only a year out so I should think about testing this PR. I wouldn't be able to do so until March, most likely.

MatthieuDartiailh commented 2 years ago

No rush. You are one of the few person I am sure run a reasonably large app in Qt so I though it might be of interest.

MatthieuDartiailh commented 2 years ago

I am happy to report that https://github.com/Exopy/exopy works out of the box with Qt6. Since this is the largest application using the Qt backend I can access I will merge this shortly. @bburan did you get a chance to test with your project ?

MatthieuDartiailh commented 2 years ago

The failure is related to recent support for PEP 621 in setuptools and a partially broken pyproject.toml at least in bytecode main. I will fix it ASAP.

MatthieuDartiailh commented 2 years ago

After fixing the condition under which the scintilla example is tested it looks all good. I will try to merge by the end of the week.