search

nucleic / enaml

Declarative User Interfaces for Python
http://enaml.readthedocs.io/en/latest/
Other
1.53k stars 130 forks source link

Add example for overridding size hints #478

Closed bburan closed 2 years ago

bburan commented 2 years ago

This addresses PR #473

MatthieuDartiailh commented 2 years ago

You can ignore the 3.7 failures, I will drop support for it in the next version (done in a pending PR)

bburan commented 2 years ago

I ran the example generator script but only committed the screenshot for the new example. I use Ubuntu, so the screenshot reflects the window decorations for that platform. Is that OK? I don't have access to a Mac OS computer.

MatthieuDartiailh commented 2 years ago

I do not have a Mac anymore so even if I were to regenerate the examples the look would change so don't worry about that. Note however that you need to include the new example in the toctree of the documentation. That will fix the documentation CI.

Otherwise the changes looks great and I am happy to know that constrained layout worked well. Anytime I need to release a new version of kiwi, I sweat a bit since if I mess up the feedback is rather fast !

MatthieuDartiailh commented 2 years ago

Thanks ! since the CIs failure are unrelated I will merge.