nucleic / enaml

Declarative User Interfaces for Python

http://enaml.readthedocs.io/en/latest/

Other

1.53k stars 130 forks source link

Coerce QTimer.singleShot ms argument to int #483

Closed frmdstryr closed 2 years ago

frmdstryr commented 2 years ago

PyQt seems to not do any more casting.. This was reported on the inkcut forum https://inkcut.org/t/it-isnt-inkcut/104/post/381/ and I was able to reproduce it.

codecov-commenter commented 2 years ago

Codecov Report

Merging #483 (060bbe6) into main (0ad2793) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   73.06%   73.06%           
=======================================
  Files         316      316           
  Lines       24125    24125           
  Branches       55       55           
=======================================
  Hits        17628    17628           
  Misses       6497     6497

MatthieuDartiailh commented 2 years ago

Thanks

MatthieuDartiailh commented 2 years ago

Do you need a bug fix release ?

frmdstryr commented 2 years ago

I can just update where it's called. Will see if people start reporting issues.