nucleic / enaml

Declarative User Interfaces for Python

http://enaml.readthedocs.io/en/latest/

Other

1.53k stars 130 forks source link

Drop use of Qt compiled resource file #488

Closed bburan closed 2 years ago

bburan commented 2 years ago

PyQt6 no longer supports *.rcc files. Just load the images directly. Also, switched to QPixmap for rendering the compass rose since that seems to be the preferred class for on-screen rendering.

Fixes #487

codecov-commenter commented 2 years ago

Codecov Report

Merging #488 (9097f1c) into main (e97409a) will decrease coverage by 0.01%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   73.16%   73.15%   -0.02%     
==========================================
  Files         317      316       -1     
  Lines       24125    24115      -10     
  Branches       55       55              
==========================================
- Hits        17652    17642      -10     
  Misses       6473     6473

MatthieuDartiailh commented 2 years ago

Nice ! I do not get why we see a segfault after pytest complete on 3.10 with pyside 6 on Linux. It is unrelated to this changes and should not block merging this.

MatthieuDartiailh commented 2 years ago

486 managed to pass at least once. Hopefully it fixes the issue (I restarted the build to see if it keeps on passing).

MatthieuDartiailh commented 2 years ago

It does not... I feel we will have to live with this one for some time except if somebody can debug locally (I personally don't have the bandwidth too). @bburan is this and #486 ready to go and do you have any other fixes pending ?

bburan commented 2 years ago

@MatthieuDartiailh I also don't have the bandwidth to debug the pyside issue. This is likely a problem in the pyside library, but can't say for sure. I don't have any additional Qt6 fixes pending at the moment. I think both #486 and this one are ready to go.