search

nucleic / enaml

Declarative User Interfaces for Python
http://enaml.readthedocs.io/en/latest/
Other
1.53k stars 130 forks source link

bump qtpy minimal required version for Qt6 #490

Closed MatthieuDartiailh closed 2 years ago

MatthieuDartiailh commented 2 years ago

Ideally this needs a test before being merged

codecov-commenter commented 2 years ago

Codecov Report

Merging #490 (3f860be) into main (e97409a) will decrease coverage by 0.01%. The diff coverage is n/a.

:exclamation: Current head 3f860be differs from pull request most recent head 6854c86. Consider uploading reports for the commit 6854c86 to get more accurate results

@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
- Coverage   73.16%   73.15%   -0.02%     
==========================================
  Files         317      316       -1     
  Lines       24125    24115      -10     
  Branches       55       55              
==========================================
- Hits        17652    17642      -10     
  Misses       6473     6473
MatthieuDartiailh commented 2 years ago

This needs a test for the dialog regression it fixes in Qt6 before merging.

MatthieuDartiailh commented 2 years ago

I looked at testing and it looks quite a bit more complicated than I thought at first. Since the issue is deep within the compatibility offered by qtpy I will merge as is.