search

nucleic / enaml

Declarative User Interfaces for Python
http://enaml.readthedocs.io/en/latest/
Other
1.53k stars 130 forks source link

Fix drag and drop on Qt6 #491

Closed MatthieuDartiailh closed 2 years ago

MatthieuDartiailh commented 2 years ago

This is based on #486

codecov-commenter commented 2 years ago

Codecov Report

Merging #491 (84f8df1) into main (6854c86) will increase coverage by 0.82%. The diff coverage is 70.00%.

:exclamation: Current head 84f8df1 differs from pull request most recent head eb24c5e. Consider uploading reports for the commit eb24c5e to get more accurate results

@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
+ Coverage   73.15%   73.98%   +0.82%     
==========================================
  Files         316      317       +1     
  Lines       24115    24135      +20     
  Branches       55       55              
==========================================
+ Hits        17642    17856     +214     
+ Misses       6473     6279     -194
MatthieuDartiailh commented 2 years ago

This is nearly ready to go. I will just try to add tests for the time editor and the popup view closing behavior. Testing the dock area dragging won't be possible except at a super low level and I don't think it is truly worth it.

MatthieuDartiailh commented 2 years ago

@bburan since we have at least basic test for everything this PR covers I suggest we merge. WDYT ?

bburan commented 2 years ago

@MatthieuDartiailh I agree. It will be difficult to test things that require dragging. For most other tests, the documentation examples should capture many of the potential issues even if we have to test them one by one by hand. That should only be necessary for major Qt releases.