nucleic / enaml

Declarative User Interfaces for Python

http://enaml.readthedocs.io/en/latest/

Other

1.53k stars 130 forks source link

core: use atom.add_member to add members after a class is defined #496

Closed MatthieuDartiailh closed 2 years ago

MatthieuDartiailh commented 2 years ago

This will require atom >= 0.9

codecov-commenter commented 2 years ago

Codecov Report

Merging #496 (1b3bdbf) into main (76eee8f) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
- Coverage   74.46%   74.46%   -0.01%     
==========================================
  Files         317      317              
  Lines       24136    24130       -6     
  Branches       55       55              
==========================================
- Hits        17974    17968       -6     
  Misses       6162     6162

frmdstryr commented 2 years ago

I have been using an old version for a while and just updated a few days ago (to atom's git master) and noticed that dock themes no longer load at startup. I can reproduce it by running the dock area example.

If I downgrade to atom 0.8.1 and revert this commit it works as expected...

Are you able to reproduce it?

MatthieuDartiailh commented 2 years ago

Yes I can reproduce. Not sure when I will have time to investigate though.