nucleic / enaml

Declarative User Interfaces for Python
http://enaml.readthedocs.io/en/latest/
Other
1.53k stars 130 forks source link

Reimplement DockArea.initialize instead of shadowing the initialized member #502

Closed MatthieuDartiailh closed 2 years ago

MatthieuDartiailh commented 2 years ago

address https://github.com/nucleic/enaml/pull/496#issuecomment-1192061589

MatthieuDartiailh commented 2 years ago

ping @frmdstryr

codecov-commenter commented 2 years ago

Codecov Report

Merging #502 (ea767f9) into main (16d72a1) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
+ Coverage   74.45%   74.47%   +0.01%     
==========================================
  Files         317      317              
  Lines       24123    24121       -2     
  Branches       55       55              
==========================================
+ Hits        17961    17964       +3     
+ Misses       6162     6157       -5     
frmdstryr commented 2 years ago

Works now, thanks!

MatthieuDartiailh commented 2 years ago

Thanks for having a look @frmdstryr