search

nucleic / enaml

Declarative User Interfaces for Python
http://enaml.readthedocs.io/en/latest/
Other
1.53k stars 130 forks source link

button_group #512

Open mervecelik11 opened 1 year ago

MatthieuDartiailh commented 1 year ago

Could you motivate your changes ?

MatthieuDartiailh commented 1 year ago

Do not worry about the CI failure I will take care of it.

mervecelik11 commented 1 year ago

Thank you

MatthieuDartiailh commented 1 year ago

Reading through your changes it seems you have misinterpreted the goal of the example, which means it can be improved.

This example demonstrate how radio buttons living in different containers can still be grouped. Radio buttons living in the same container are grouped by default which is not demonstrated by this example and maybe it should. Your changes make use of this mechanism but completely remove the original intent of the example.

We should try to expand the example to do both: demonstrate the default behavior and the more flexible one.