Closed bburan closed 1 year ago
Merging #523 (21296f7) into main (b54467b) will decrease coverage by
0.04%
. The diff coverage is0.00%
.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Sadly QTest is quite bugged when it comes to anything resembling a dragging operation which is what is needed here to test, so you won't be able to add a test I fear.
The changes look good to me but I wil try to dig a bit in the numerous CI failures. I missed that so many of them were systematic. Do not hesitate to ping me if I forget. I also have to deal with #480 at one point.
@MatthieuDartiailh FYI the latest release of Enaml on pypi has this bug and it causes applications to crash if the user attempts to drag a tabbed item out of a dock. Right now I'm using a custom-patched version of Enaml on all the computers I have my application installed on so it's not a high priority for me. However, I'm not sure if other users may be affected by this.
I will try to merge the fix and re-release ASAP. My open source time is very limited so I won't be able to investigate the Qt issues any time soon so there is no point in delaying this fix.
This fixes the following error when attempting to use the mouse to undock a dock item that's part of a tab group:
I tried updating the unit-tests to catch this issue, but could not even figure out how to click on a dock item titlebar. For example, this code should work, but even during the
enaml_qtbot.wait(5000)
, I see no evidence thatitem_7
was activated in the dock area (this is using thetest_dock_layout.py
).I'm guessing if we can figure out a way to properly target one of the dock items in a tab group, then we would do
mousePress
followed by amouseMove
to some other area which would capture the bug.