search

nucleic / enaml

Declarative User Interfaces for Python
http://enaml.readthedocs.io/en/latest/
Other
1.52k stars 130 forks source link

Fix code generation for inserted Python block on Python 3.10+ #528

Closed MatthieuDartiailh closed 1 year ago

MatthieuDartiailh commented 1 year ago

On Python 3.11 in particular one can often find a last block which acts as an error handling block which should not be connected to the code we want to append after the block.

MatthieuDartiailh commented 1 year ago

Rely on https://github.com/MatthieuDartiailh/bytecode/pull/120 against which we are testing to ensure the fix there is correct.

codecov-commenter commented 1 year ago

Codecov Report

Merging #528 (51e23cd) into main (c4152e2) will not change coverage. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #528 +/- ## ======================================= Coverage 72.65% 72.65% ======================================= Files 287 287 Lines 24417 24417 Branches 4343 4343 ======================================= Hits 17740 17740 Misses 5591 5591 Partials 1086 1086 ```
MatthieuDartiailh commented 1 year ago

closes #521