search

nucleic / enaml

Declarative User Interfaces for Python
http://enaml.readthedocs.io/en/latest/
Other
1.52k stars 130 forks source link

Fix potential error in rewrite fast locals on 3.12 for #548 #550

Closed frmdstryr closed 2 months ago

frmdstryr commented 3 months ago

Adds a few isinstance checks needed in rewrite_fast_locals on python 3.12. Fixes #548

codecov[bot] commented 3 months ago

Codecov Report

Merging #550 (0b34df4) into main (bf0ea6f) will increase coverage by 0.00%. Report is 1 commits behind head on main. The diff coverage is 100.00%.

:exclamation: Current head 0b34df4 differs from pull request most recent head 0e980a9. Consider uploading reports for the commit 0e980a9 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #550 +/- ## ======================================= Coverage 70.74% 70.75% ======================================= Files 287 287 Lines 25634 25638 +4 Branches 4676 4678 +2 ======================================= + Hits 18135 18139 +4 Misses 6386 6386 Partials 1113 1113 ```
MatthieuDartiailh commented 3 months ago

Thanks for the PR. I will try to look into the bytecode causing the error before merging to understand why 3.12 uses a try/begin here.

MatthieuDartiailh commented 2 months ago

Thanks for the fix. Would you be so kind as to add an entry in the changelog ?