search

nucleic / kiwi

Efficient C++ implementation of the Cassowary constraint solving algorithm
https://kiwisolver.readthedocs.io/en/latest/
Other
692 stars 88 forks source link

License info on PyPI contains complete license text #137

Closed cmeessen closed 2 years ago

cmeessen commented 2 years ago

The license info on PyPI contains the complete license text:

image

It is common practice to use only the identifier for the license. If I am not wrong, in your case the corresponding SPDX Identifier should be BSD-3-Clause.

It would be great if you fix this in PyPI. We are having issues with automated license analysis of our dependencies, because the PyPI license string of the kiwisolver cannot be evaluated properly.

Thanks :)

MatthieuDartiailh commented 2 years ago

When I read the specification for this field in PEP 621 (https://peps.python.org/pep-0621/#dependencies-optional-dependencies) I believe what I am doing is legitimate. For your purpose I am wondering if looking at classifiers wouldn't be better.

cmeessen commented 2 years ago

Fair enough, that's a good point. We will look into it and fix it. Thanks for the quick response, I will close the issue.

sccolbert commented 2 years ago

Please keep in mind, phrases like:

“It would be great if you fix… it’s causing issues with our…”

Are one of the big reasons I left software development. It simply reeks of entitlement.

First, it presupposes something is wrong with the OSS project, when in this case the issue is on the user’s side.

Second, even if there was a problem with the OSS project, why should I care if it causes you issues if you can’t even muster a “please” while expecting it to be fixed. You use this software for free, and obviously derive value from it. So at least be humble in your communications.

Third, asking a project to change their license text, after almost a decade in use, is no small request. It should not be treated so flippantly.

Finally, I assume from your last name that you are not a native English speaker, so I excuse you for a lot of this. However, native speakers do this all the time too, so I figured I’d say my thoughts on the matter while it’s fresh.

On Mon, Apr 4, 2022 at 07:32 Christian Meeßen @.***> wrote:

Closed #137 https://github.com/nucleic/kiwi/issues/137.

— Reply to this email directly, view it on GitHub https://github.com/nucleic/kiwi/issues/137#event-6362625880, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABBQSK44AD7EQYMDF4POZLVDLOPJANCNFSM5SOUH3UQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

cmeessen commented 2 years ago

Thank you for your communicating your thoughts. I apologise that my request sounded rude or presumptuous, it was not meant like that. I will consider your points in the future and take more time for better phrasing. My intention was to point out that kiwisolver is doing something that most others are doing in a different way.

I would like to expand on the third point you mention, because I think this one was misunderstood. I did not mean to ask to change the actual license of the project. The license text in LICENSE corresponds to the BDS-3-Clause. That license is sometimes also called "New" or "Revised" which is the title in the license file. Since the vast majority of package providers on PyPI use a text that mostly corresponds to the SPDX Identifier, I was confused to find the complete license text in there. From my point of view, the project's PyPI page may have benefited from stating only the identifier. Especially, because SPDX identifiers are machine readable. My apologies that I did not communicate this properly.

sccolbert commented 2 years ago

Thank you for clarifying the last point. I totally misunderstood what you were asking for. I apologize for that point.

On Tue, Apr 5, 2022 at 03:56 Christian Meeßen @.***> wrote:

Thank you for your communicating your thoughts. I apologise that my request sounded rude or presumptuous, it was not meant like that. I will consider your points in the future and take more time for better phrasing. My intention was to point out that kiwisolver is doing something that most others are doing in a different way.

I would like to expand on the third point you mention, because I think this one was misunderstood. I did not mean to ask to change the actual license of the project. The license text in LICENSE https://github.com/nucleic/kiwi/blob/main/LICENSE corresponds to the BDS-3-Clause https://opensource.org/licenses/BSD-3-Clause. That license is sometimes also called "New" or "Revised" which is the title in the license file. Since the vast majority of package providers on PyPI use a text that mostly corresponds to the SPDX Identifier, I was confused to find the complete license text in there. From my point of view, the project's PyPI page may have benefited from stating only the identifier. Especially, because SPDX identifiers are machine readable. My apologies that I did not communicate this properly.

— Reply to this email directly, view it on GitHub https://github.com/nucleic/kiwi/issues/137#issuecomment-1088444925, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABBQSIGDMW35RM7GZJKEX3VDP54JANCNFSM5SOUH3UQ . You are receiving this because you commented.Message ID: @.***>