nucleic / kiwi

Efficient C++ implementation of the Cassowary constraint solving algorithm

https://kiwisolver.readthedocs.io/en/latest/

Other

679 stars 88 forks source link

Update shareddata.h #149

Closed sccolbert closed 2 years ago

sccolbert commented 2 years ago

Don't decref the old m_data object until all other references to it are gone, as its destructor may have arbitrary side effects.

ping @MatthieuDartiailh

codecov-commenter commented 2 years ago

Codecov Report

Merging #149 (92cf869) into main (a29e692) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   87.40%   87.40%           
=======================================
  Files          24       24           
  Lines        1604     1604           
  Branches       74       74           
=======================================
  Hits         1402     1402           
  Misses        184      184           
  Partials       18       18

MatthieuDartiailh commented 2 years ago

Thanks a lot @sccolbert !

MatthieuDartiailh commented 2 years ago

I will merge as soon as I find the time to update the release notes.